Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mustache specs - method interpolation compliance #305

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

danielfagerstrom
Copy link
Contributor

According to the Mustache spec if the name parts in a doted name refers to methods, these methods should be called in the context of the object they are contained in. In mustache.js only the last name in a doted name is called (if it is a function) and it is called in the context of the current view object rather than in the context of its object.

I try to use mustache.js on nested objects that contain accessor methods and it would be much easier if mustache.js followed the behavior from the spec. And I have therefore implemented that behavior.

If we e.g. have a interpolation {{foo.bar}} where foo is a method in the current view that returns a object o with a bar method, foo will be called in the context of the current view and bar will be called in the context of o.

Unfortunately this change break some current function behavior, I have updated one of the tests and the documentation to reflect this. And provided tests for the new behavior.

…bda should be interpolated. This breaks one of the current tests of lambdas (higher order sections), as it asumes that the result is not interpolated. I updated the test so that it pass.
…d calls. All metods in a name path should be called in the context of their containing object. In current mustache.js only the last name in a path is called and it is called in the context of the name lookup rather than of its object. This patch breaks the current behaviour, so I provided an extra context parameter to make it easier to update programs using the current function context behaviour. A breaking test is fixed and there are new tests for method calls etc.
Updated documentation for the new method interpolation behavior.
@mjackson
Copy link
Collaborator

mjackson commented Apr 4, 2013

@danielfagerstrom I've merged in the first few commits in this pull request. Would you please remove them from this request and limit the scope of this pull request to only the commits that have to do with method interpolation compliance? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants