Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing semicolon in test/cli-test.js #777

Merged
merged 1 commit into from Apr 12, 2021
Merged

Fix missing semicolon in test/cli-test.js #777

merged 1 commit into from Apr 12, 2021

Conversation

Mejia1994
Copy link
Contributor

when run npm test it shows

test\cli-test.js 13:85 error Missing semicolon semi

phillipj added a commit that referenced this pull request Apr 12, 2021
@phillipj
Include linting of test/*.js in npm run test-lint script
af216b0 
Had obviously been forgotten, but those test files should have been part
of the ordinary lint phase.

The fact that we had forgotten to lint these files, allowed a missing
semi-colon to sneak into `./test/cli-test.js` file.

Refs #777
@phillipj
Copy link
Collaborator

Thanks for pointing this out!

It should obviously have been caught in the CI runs, but you made me aware all test/*.js files was lacking in our linting step.

Fixed that now (in af216b0) so this won't happen again.

@phillipj phillipj changed the title missing semicolon Fix missing semicolon in test/cli-test.js Apr 12, 2021
@phillipj phillipj merged commit e53a6e8 into janl:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mejia1994 @phillipj @mejiaest